From khali@linux-fr.org Sat Jun 4 04:17:21 2005 Date: Sat, 4 Jun 2005 13:17:43 +0200 From: Jean Delvare To: Greg KH Cc: Aurelien Jarno Subject: I2C: pcf8574 driver cleanup Message-Id: <20050604131743.1a13baad.khali@linux-fr.org> I found a possible cleanup in the pcf8574 driver. We don't need to store the read value in our private data structure, as we then never use it again. I asked Aurelien and he is fine with the change. Please apply, thanks. Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/chips/pcf8574.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) --- gregkh-2.6.orig/drivers/i2c/chips/pcf8574.c 2005-06-05 22:30:27.000000000 -0700 +++ gregkh-2.6/drivers/i2c/chips/pcf8574.c 2005-06-05 23:06:29.000000000 -0700 @@ -57,7 +57,7 @@ struct pcf8574_data { struct i2c_client client; - u8 read, write; /* Register values */ + u8 write; /* Remember last written value */ }; static int pcf8574_attach_adapter(struct i2c_adapter *adapter); @@ -79,9 +79,7 @@ static ssize_t show_read(struct device *dev, struct device_attribute *attr, char *buf) { struct i2c_client *client = to_i2c_client(dev); - struct pcf8574_data *data = i2c_get_clientdata(client); - data->read = i2c_smbus_read_byte(client); - return sprintf(buf, "%u\n", data->read); + return sprintf(buf, "%u\n", i2c_smbus_read_byte(client)); } static DEVICE_ATTR(read, S_IRUGO, show_read, NULL);